fix: pass complete security context to pods #1679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niklas Treml <[email protected]>
niklastreml
force-pushed
the
fix/supplemental-groups
branch
from
560278e
to
37a91ac
Compare
pepov
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fixes an issue with the operator when deploying a FluentdConfig in our cluster. We have a security policy, that enforces our users to set a security context on their pods. We noticed that it was not possible to deploy a fluentd using the FluentdConfig resource, because the ConfigCheck and the FluentD pod would violate our policies, even when
Security.SecurityContextandSecurity.PodSecurityContextwere set correctly, because they were missingsupplementalGroups. After some investigation, we found, that the pods that are created by the operator only had some of the values set on the security object in the FluentdConfig resource. This PR updates the fluentd statefulset and its components, so they should now include the whole securityContext object. I tested this locally and everything seemed to work fine.